Ticket #842 (new defect)

Opened 2 months ago

ndas 1.1-24 scsi modules do not build with kernel < 2.6.22

Reported by: henry@stern.ca Assigned to: hootch
Priority: normal Milestone: 1.1
Component: xplat Version: 1.1-XX
Severity: blocker Keywords:
Cc: Kernel Version (Result of "uname -r"): 2.6.18-6-686
Linux Distribution: Debian cpu/chip: i386
Linux Dist Version: etch

Description

Line 942 of scsi/ndas_scsi.c uses a kernel macro, list_first_entry, that was introduced in kernel 2.6.22. This breaks the build for earlier kernels, particularly the stock kernel of Debian stable (etch).

Thankfully, it's quite easy to fix. Change line 942 of scsi/ndas_scsi.c from:

pc = list_first_entry(&ndas_dev->q_list_head, struct ndas_scsi_pc, q_entry);

to:

pc = list_entry((&ndas_dev->q_list_head)->next, struct ndas_scsi_pc, q_entry);

Ref: http://linux.derkeiler.com/Mailing-Lists/Kernel/2007-04/msg05893.html http://kerneltrap.org/man/linux/man9/list_first_entry.9

Attachments


Add/Change #842 (ndas 1.1-24 scsi modules do not build with kernel < 2.6.22)